Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linux/android rules and reduce fps for intel-specific rules #927

Merged
merged 2 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ rule:
- or:
- api: DbgPrint
- api: kernel32.OutputDebugString
- and:
- os: android
- api: __android_log_print
3 changes: 3 additions & 0 deletions lib/calculate-modulo-256-via-x86-assembly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ rule:
# and ecx, 800000FFh
# and ecx, 0FFh
- and:
- or:
- arch: i386
- arch: amd64
Comment on lines +18 to +20
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and + 0xFF appear very frequently in ARM resulting in FPs for dependent rules, so we limit this rule to Intel archs

- mnemonic: and
- or:
- number: 0x800000FF
Expand Down
19 changes: 19 additions & 0 deletions nursery/delete-file-on-linux.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
rule:
meta:
name: delete file on Linux
namespace: host-interaction/file-system/delete
authors:
- mehunhoff@google.com
scopes:
static: basic block
dynamic: call
mbc:
- File System::Delete File [C0047]
features:
- and:
- or:
- os: linux
- os: android
- or:
- api: unlink
- api: unlinkat
Loading