Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create read-virtual-disk.yml #183

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Create read-virtual-disk.yml #183

merged 1 commit into from
Dec 2, 2020

Conversation

re-fox
Copy link
Collaborator

@re-fox re-fox commented Nov 18, 2020

This addresses #177 which handles reading Virtual Disk files.

I included the constants that make up the guid (shown below) as optional. Due to the number of variations that could exist.

    static GUID VIRTUAL_STORAGE_TYPE_VENDOR_MICROSOFT_EX = { 0xEC984AEC ,0xA0F9, 0x47e9, 0x901F, 0x71415A66345B };

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the references!

@williballenthin
Copy link
Collaborator

williballenthin commented Nov 19, 2020

Due to the number of variations that could exist.

thoughts on a guid: {....} feature that expands into various ways of encoding it?

pro: makes it easier for rule authors
pro: could hook into an encyclopedia of GUIDs to enable use of symbolic names, too
con: single feature would expand into multiple features to support this, which could be complex to implement/display (think about single string reference vs bunch of immediate constants).

@re-fox
Copy link
Collaborator Author

re-fox commented Nov 19, 2020

That's a great idea.

Rather than searching for string regexes related to GUIDs/CLSIDs/IIDs, mapping them to a feature would facilitate rapid capability discovery. This would also assist in ID'ing COM objects as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants