Replaced therubyracer with ExecJS #24
Conversation
|
CC: @eemi |
|
If it helps, we can test it tomorrow in our Windows 7 machines. |
|
@daniel-rikowski thanks for the PR! It Works on my Machine™, although it seems to be yielding different results - which, on first thought, I think it shouldn't. I'll come back later when I'm able to test it a little bit further. As always, any comments will be appreciated 👍 |
|
I noticed that, too. Different JS engines produce different results, judging from a superficial glance in the editor. I blamed it on internal differences in the JS interpreters, like different hash algorithms, string collations or other unspecified implementation details. I did not thoroughly check if the results were fundamentally different (like missing keywords and such) |
|
I've tested this branch locally. It fixes issues I was having with middleman hanging when running in dev mode (seems similar to middleman/middleman#1367). I also generated the index with this branch and with middleman-search 0.10.0 and got the same output. Would be great if this could be merged. |
Pull in ExecJS based approach from this pull request: manastech#24
|
Please merge this PR. I have several issues installing |
This may be temporary, but we are going to publish our fork to rubygems under another name. This will allow us to include this version as a dependency in the govuk_tech_docs gem we publish here: https://rubygems.org/gems/govuk_tech_docs The difference between this and upstream is a change from therubyracer to execjs. This fixes problems with middleman hanging in dev mode. See manastech#24 for more details.
No description provided.