Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elao - Infra] Upgrade terraform + add ovh plugin #29

Merged
merged 1 commit into from
Mar 10, 2020
Merged

[Elao - Infra] Upgrade terraform + add ovh plugin #29

merged 1 commit into from
Mar 10, 2020

Conversation

hyvs
Copy link
Member

@hyvs hyvs commented Mar 4, 2020

  • upgrade provider openstack v1.26.0
  • add provider ovh v0.7.0
  • add provider template v2.1.2
  • add public cloud project name in zsh prompt

@nervo nervo changed the title Upgrade terraform + add ovh plugin [Elao - Infra] Upgrade terraform + add ovh plugin Mar 9, 2020
nervo
nervo reviewed Mar 9, 2020
View reviewed changes
elao.infra/.manala/docker/Dockerfile.terraform.tmpl
@@ -1,21 +1,37 @@
FROM golang:alpine3.9 AS provider-openstack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi, base image such as golang:alpine3.9 could be defined as an ARG to avoid repetition :)
(let's keep that for alpine 3.11 upgrade)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to know 👍

@hyvs hyvs merged commit 111bbfe into master Mar 10, 2020
@hyvs hyvs deleted the upgrade-infra-terraform branch March 10, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nervo nervo nervo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyvs @nervo