Change default encoding to binary, instead of hex #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes a few changes, but most importantly, we define a breaking change to make the default encoding of an RLP structure the binary encoding (e.g. <<0x55, 0x66, 0x77>>) instead of hex (e.g. "556677"). This is because the binary encoding is faster and more appropriate when encoding and decoding RLP from the blockchain. We allow a user of ExRLP to return to hex encoding by specifying `encoding: :hex` in the options hash. Additionally, we merge the test cases from another RLP library and add typespecs for dialyzer.
|
@hayesgm can you bump version and describe your changes in CHANGELOG, please? |
We've made a non-backwards compatable change (changing the default encoding to binary instead of hex), and thus we'll bump the version up a minor (since we're still less than 1.0.0). Added notes on what has changed.
masonforest
pushed a commit
that referenced
this pull request
Apr 13, 2018
Change default encoding to binary, instead of hex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes a few changes, but most importantly, we define a breaking change to make the default encoding of an RLP structure the binary encoding (e.g. <<0x55, 0x66, 0x77>>) instead of hex (e.g. "556677"). This is because the binary encoding is faster and more appropriate when encoding and decoding RLP from the blockchain. We allow a user of ExRLP to return to hex encoding by specifying
encoding: :hexin the options hash.Additionally, we merge the test cases from another RLP library and add typespecs for dialyzer.