Fix eth_estimate_gas typespec #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrat555
reviewed
Dec 28, 2018
| params = [transaction, block] | ||
| @spec eth_estimate_gas(map(), keyword()) :: {:ok, binary()} | error | ||
| def eth_estimate_gas(transaction, opts \\ []) do | ||
| params = [transaction] |
There was a problem hiding this comment.
I think it accepts two parameters
There was a problem hiding this comment.
While that's what I got after reading Ethereum JSON RPC wiki, I can't find any examples of people using it like that - every single example I found doesn't specify the block type. Also, after removing the block parameter, the related test passed.
With current implementation, I keep getting {:error, %{"code" => -32602, "message" => "too many arguments, want at most 1"}}
If I misunderstood the spec, would really appreciate if you could comment on that.
There was a problem hiding this comment.
ok. I'll look into it on the weekend
ayrat555
force-pushed
the
typespec-fix
branch
from
bddd574 to
7a537f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.