Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings #159

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Fix deprecation warnings #159

merged 2 commits into from
Oct 6, 2021

Conversation

tirkarthi
Copy link
Contributor

Fixes #157
Fixes #158

@bmoscon bmoscon requested a review from eeaston April 11, 2020 14:19
@bmoscon
Copy link
Collaborator

bmoscon commented Apr 11, 2020

I'll defer to @eeaston

@eeaston - by the way - any consideration for dropping python2 support? Would clean up a lot of the code!

@webknjaz
Copy link

webknjaz commented Oct 6, 2021

@bmoscon looks like nobody needs this working on Python 3.10 anymore?

jonbannister
jonbannister approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jonbannister jonbannister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonbannister jonbannister merged commit 2929621 into man-group:master Oct 6, 2021
@tirkarthi
Copy link
Contributor Author

Thanks all for the reviews and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbannister jonbannister jonbannister approved these changes

@bmoscon bmoscon bmoscon approved these changes

@jayvdb jayvdb jayvdb approved these changes

@eeaston eeaston Awaiting requested review from eeaston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@tirkarthi @bmoscon @webknjaz @jayvdb @jonbannister