Test against Python 3.7 and support pytest 4.x #130

jcfr · 2019-03-05T20:00:48Z

This PR adds support for Python 3.7 and will be updated to address #100, #110, #92 , #125

jcfr · 2019-03-05T21:29:26Z

For reference, setting COVERALLS_REPO_TOKEN is required to use coveralls python client or to submit coverage results using curl. Failing to do so reports Couldn't find a repository matching this job.
See lemurheavy/coveralls-public#487 and https://github.com/z4r/python-coveralls#configuration

See https://circleci.com/docs/2.0/configuration-reference/#machine

The current implementation needs to be refactored to support the latest release of rethinkdb-python package. See man-group#132

…d 3.x See man-group#125

…roup#122

See man-group#100

This commit fixes the following error: > root_uri.append(request.getfuncargvalue('pyramid_server').uri) E RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue pytest_webdriver.py:62: RemovedInPytest4Warning See man-group#100

…cture This commit fixes tests failing with pytest > 4.0.0

…= 4.1.0 This commit updates tests to support version of pytest with pytest-dev/pytest@e9b2475e2 (Display actual test ids in `--collect-only`)

Wheel is currently considered the standard for built and binary packaging for Python See https://packaging.python.org/discussions/wheel-vs-egg/ See man-group#125

jcfr · 2019-03-08T00:06:59Z

@bmoscon @eeaston @javefang This is now ready for final review.

It addresses issues #125 #122 #110 and #100

After getting your feedback, I will also:

update CHANGES.md
update the install_all target in the Makefile so that python 3.7 is also installed in Vagrantfile

Once, this is done it would be great to cut a release and have all the wheels uploaded to pypi. This will all me to fix testing associated with cmake-python-distributions, ninja-python-distributions and scikit-build

Cc: @thewtex

bmoscon · 2019-03-08T19:50:45Z

@eeaston @javefang looks good to me, but given the size and scope of the change I'd like to have another review before merging

jcfr · 2019-03-09T06:12:27Z

Et voila. The last two updates have been pushed. Now looking forward final reviews.

In the mean time and waiting new official wheels are released, temporary ones are available at https://github.com/jcfr/pytest-plugins/releases/tag/v1.7.0.dev15

They can be installed using:

pip install pytest-virtualenv -f https://github.com/jcfr/pytest-plugins/releases/tag/v1.7.0.dev15 --pre

javefang · 2019-03-11T06:59:51Z

LGTM, thanks for the contribution!
@eeaston , I tested the branch against pytest==3.1.0 which is also a pass.

ssbarnea · 2019-03-13T17:49:39Z

When can have this merged as now I went into conflicts caused by:

pytest-verbose-parametrize 1.5.1 has requirement pytest<4.0.0, but you have pytest 4.3.1.

jcfr · 2019-03-13T17:51:29Z

@ssbarnea As a temporary workaround, you could install corresponding development wheels. See #130 (comment)

ssbarnea · 2019-03-13T17:58:01Z

@jcfr Thanks for the hint but I will have to pass. I would not be able to do this even if the pre-release would be on posted on pypi as we have a policy of not using unreleased dependencies (not a real surproise).

For the moment I added a <4.0.0 on pytest with a comment blaming pytest-verbose-parametrize as being the reason.

bmoscon · 2019-03-19T16:04:37Z

@eeaston this ok to merge? I'll probably squash and merge it soon unless you want to review/comment

jcfr · 2019-03-20T16:41:03Z

'll probably squash and merge it soon unless you want to review/comment

For convenience, here is a squashed version of that same topic:

#134

eeaston · 2019-03-20T18:09:42Z

Hi guys apologies for the tardy replies.
@jcfr - amazing PR, many thanks for the hard work, I'll start going through it.

eeaston · 2019-03-20T18:21:29Z

LGTM, many thanks! I'll approve the squashed PR #134

jcfr · 2019-03-20T18:22:47Z

I'll approve the squashed PR #134

Closing this one.

ci: Test against Python 3.7

cc017ff

bmoscon requested review from bmoscon, javefang and eeaston and removed request for bmoscon and javefang March 5, 2019 20:08

ci: Skip Coveralls submission if COVERALLS_REPO_TOKEN env. var is empty

175271e

jcfr force-pushed the support-python3.7-and-pytest-4.x branch from 43e6ce8 to 175271e Compare March 5, 2019 21:23

ci: Update circleci image to allow install of python 3.7

f91b893

See https://circleci.com/docs/2.0/configuration-reference/#machine

jcfr force-pushed the support-python3.7-and-pytest-4.x branch from fe428b2 to f91b893 Compare March 5, 2019 22:53

bmoscon requested a review from javefang March 6, 2019 17:46

pytest-server-fixture: Fix rethinkdb tests requiring rethinkdb < 2.4.0

884e5b5

The current implementation needs to be refactored to support the latest release of rethinkdb-python package. See man-group#132

jcfr force-pushed the support-python3.7-and-pytest-4.x branch 2 times, most recently from 654d32f to cc04b79 Compare March 7, 2019 06:57

wheels: Generate universal wheels installable with both python 2.x an…

deded3b

…d 3.x See man-group#125

jcfr force-pushed the support-python3.7-and-pytest-4.x branch from cc04b79 to deded3b Compare March 7, 2019 07:07

jcfr added 7 commits March 7, 2019 02:21

Fix DeprecationWarning warnings using "logger.warning()" function

4e7a660

pytest-virtualenv: Add virtualenv as install requirement. Fixes man-g…

472a16d

…roup#122

Remove requirement for pytest<4.0.0

6382e77

See man-group#100

pytest-verbose-parametrize: Add support for revamped marker infrastru…

2318813

…cture This commit fixes tests failing with pytest > 4.0.0

pytest-verbose-parametrize: Fix integration tests to support pytest >…

3c54816

…= 4.1.0 This commit updates tests to support version of pytest with pytest-dev/pytest@e9b2475e2 (Display actual test ids in `--collect-only`)

dist: Remove support for building and distributing *.egg files

dd239fd

Wheel is currently considered the standard for built and binary packaging for Python See https://packaging.python.org/discussions/wheel-vs-egg/ See man-group#125

bmoscon approved these changes Mar 8, 2019

View reviewed changes

jcfr added 2 commits March 9, 2019 01:01

VagrantFile: Install python 3.7 and initialize python 3.7 by default

1fe1b61

Update CHANGES.md [ci skip]

3453df8

javefang approved these changes Mar 11, 2019

View reviewed changes

ssbarnea approved these changes Mar 13, 2019

View reviewed changes

jcfr closed this Mar 20, 2019

jcfr deleted the support-python3.7-and-pytest-4.x branch March 20, 2019 18:22

eeaston mentioned this pull request Mar 20, 2019

Please include wheels for modern Pythons #125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test against Python 3.7 and support pytest 4.x #130

Test against Python 3.7 and support pytest 4.x #130

jcfr commented Mar 5, 2019

jcfr commented Mar 5, 2019

jcfr commented Mar 8, 2019 •

edited

Loading

bmoscon commented Mar 8, 2019

jcfr commented Mar 9, 2019

javefang commented Mar 11, 2019

ssbarnea commented Mar 13, 2019

jcfr commented Mar 13, 2019

ssbarnea commented Mar 13, 2019

bmoscon commented Mar 19, 2019

jcfr commented Mar 20, 2019 •

edited

Loading

eeaston commented Mar 20, 2019

eeaston commented Mar 20, 2019

jcfr commented Mar 20, 2019

Test against Python 3.7 and support pytest 4.x #130

Test against Python 3.7 and support pytest 4.x #130

Conversation

jcfr commented Mar 5, 2019

jcfr commented Mar 5, 2019

jcfr commented Mar 8, 2019 • edited Loading

bmoscon commented Mar 8, 2019

jcfr commented Mar 9, 2019

javefang commented Mar 11, 2019

ssbarnea commented Mar 13, 2019

jcfr commented Mar 13, 2019

ssbarnea commented Mar 13, 2019

bmoscon commented Mar 19, 2019

jcfr commented Mar 20, 2019 • edited Loading

eeaston commented Mar 20, 2019

eeaston commented Mar 20, 2019

jcfr commented Mar 20, 2019

jcfr commented Mar 8, 2019 •

edited

Loading

jcfr commented Mar 20, 2019 •

edited

Loading