Fix SegmentHeader::clone()

Cloning did not copy over all fields. The `MockS3Storage` relies on cloning segments and this makes it usable for all cases.
man-group · Jan 31, 2025 · ff22094 · ff22094
1 parent 32fa78f
commit ff22094
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cpp/arcticdb/codec/encoded_field_collection.hpp b/cpp/arcticdb/codec/encoded_field_collection.hpp
@@ -68,7 +68,10 @@ class EncodedFieldCollection {
     EncodedFieldCollection() = default;
 
     [[nodiscard]] EncodedFieldCollection clone() const {
-        return {data_.clone(), offsets_.clone()};
+        auto output = EncodedFieldCollection{data_.clone(), offsets_.clone()};
+        output.count_ = count_;
+        output.offset_ = offset_;
+        return output;
     }
 
     ARCTICDB_MOVE_ONLY_DEFAULT(EncodedFieldCollection)

diff --git a/cpp/arcticdb/codec/segment_header.hpp b/cpp/arcticdb/codec/segment_header.hpp
@@ -50,6 +50,7 @@ class SegmentHeader {
         output.header_fields_ = header_fields_.clone();
         output.body_fields_ = body_fields_.clone();
         output.offset_ = offset_;
+        output.field_count_ = field_count_;
         return output;
     }