pin micromamba default version to 1.* #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
reviewed
Oct 3, 2024
| @@ -146,7 +146,7 @@ const inferOptions = (inputs: Inputs): Options => { | |||
| // if micromambaUrl is specified, use that, otherwise use micromambaVersion (or 'latest' if not specified) | |||
| const micromambaSource = inputs.micromambaUrl | |||
| ? right(inputs.micromambaUrl) | |||
| : left(inputs.micromambaVersion || 'latest') | |||
| : left(inputs.micromambaVersion || '1.5.10-0') | |||
There was a problem hiding this comment.
this would require updating the GHA each time a 1.x is released, which I find fragile, but I don't have a better solution for now.
There was a problem hiding this comment.
every other solution would imply some weird api calls to get the latest v1 version which could also break
|
@pavelzw are you tagging a new release of the GHA? |
|
Thanks a lot for the quick fix and release!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.