Fix build CI #94
Fix build CI #94
Conversation
3.3.0 broke the API...
| run: | | ||
| pip install -e . | ||
| python -m pip install -e . | ||
| working-directory: ${{ inputs.server_folder }} | ||
|
|
||
| - name: Install the frontend | ||
| shell: bash |
There was a problem hiding this comment.
bash -l {0} may be missing here as well?
We can also define it as part of the defaults settings: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-set-the-default-shell-and-working-directory
There was a problem hiding this comment.
Thanks for the tip. Apparently it is not supported within a custom action definition
|
Awesome! |
| ref: master | ||
| path: ${{ inputs.server_folder }} | ||
|
|
||
| - uses: conda-incubator/setup-miniconda@v2 |
There was a problem hiding this comment.
Do you think we could use our micromamba action here?
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the suggestion.
Is it possible to set up package caching with that action?
|
Happy to merge this. Do you want to squash commits a bit or shoudl we keep this history? |
I usually like to apply Squash and Merge instead of simple Merge on my PR. So feel free to do so with this PR. |
|
Done! Thanks! Some people don't like all commits squashed :) |
Got hit by a breaking API in
react-notifications-componentv3.3.0