Adds support for disabling extensions #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollonval
reviewed
Feb 4, 2022
packages/application/src/app.ts
Outdated
| /** | ||
| * Construct a new App object. | ||
| * | ||
| * @param options The instantiation options for an application. | ||
| */ | ||
| constructor(options: App.IOptions = {}) { | ||
| constructor(options: App.IOptions = { shell: new Shell() }) { |
There was a problem hiding this comment.
This is unneeded as L38 gets us covered.
Suggested change
| constructor(options: App.IOptions = { shell: new Shell() }) { | |
| constructor(options: App.IOptions = {}) { |
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["jupyter_packaging~=0.10,<2", "jupyterlab~=3.0"] | |||
| requires = ["jupyter_packaging~=0.10,<2"] | |||
packages/application/src/app.ts
Outdated
| @@ -24,12 +25,14 @@ export type QuetzFrontEndPlugin<T> = IPlugin<QuetzFrontEnd, T>; | |||
| * App is the main application class. It is instantiated once and shared. | |||
| */ | |||
| export class App extends Application<Shell> { | |||
| private _info: JupyterLab.IInfo = JupyterLab.defaultInfo; | |||
There was a problem hiding this comment.
I would not reuse JupyterLab.IInfo as is because for now I don't see the point of having the attribute other than deferred and disabled.
|
Thanks for the review, @fcollonval! I have pushed a commit to apply the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for disabling extensions.
Removes mime extensions
Pins typescript to
~4.1.3