Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter releaser #108

Merged
merged 8 commits into from
Aug 11, 2022
Merged

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Mar 18, 2022

  • Bump npm packages

@fcollonval fcollonval marked this pull request as draft March 18, 2022 08:10
@fcollonval fcollonval added the maintenance Maintenance and upkeep improvements label Mar 18, 2022
@hbcarlos hbcarlos marked this pull request as ready for review August 10, 2022 21:58
@hbcarlos
Copy link
Contributor

To bump the version, I added a simple script that runs lerna version and the python package takes the version from the package.json of the main app.

There are two small issues:
1- I made the @quetz-fronted/builder private because the latest version is 3.1.0 instead of 0.3.1 as every other package, so when bumping the version, it changes to 0.3.2 as every other package :( I'm not sure what to do with it.

2 - The draft-changelog step fails saying that there is a conflict when committing the changes see here. I don't understand what is happening. If we skip the step in the pyproject.toml it works, and the changelog is updated in the artifacts.

@fcollonval
Copy link
Member Author

To bump the version, I added a simple script that runs lerna version and the python package takes the version from the package.json of the main app.

👍

There are two small issues: 1- I made the @quetz-fronted/builder private because the latest version is 3.1.0 instead of 0.3.1 as every other package, so when bumping the version, it changes to 0.3.2 as every other package :( I'm not sure what to do with it.

That package is gonna be required by extensions to build their final assets. So it cannot be made private. As we were luckily still in the criteria, I unpublished all versions. So it should be safe to publish a new version aligning it with the other packages.

2 - The draft-changelog step fails saying that there is a conflict when committing the changes see here. I don't understand what is happening. If we skip the step in the pyproject.toml it works, and the changelog is updated in the artifacts.

There is a bug currently with the releaser - not related to this PR...: jupyter-server/jupyter_releaser#360

@hbcarlos
Copy link
Contributor

That package is gonna be required by extensions to build their final assets. So it cannot be made private. As we were luckily still in the criteria, I unpublished all versions. So it should be safe to publish a new version aligning it with the other packages.

Thanks!! I made it public again.

@hbcarlos
Copy link
Contributor

There is a bug currently with the releaser - not related to this PR...: jupyter-server/jupyter_releaser#360

Thanks, @fcollonval.

Can we merge this PR and try to make a release?
Is there a workaround for this issue?

Copy link
Member Author

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to merge

@hbcarlos hbcarlos merged commit 006cf45 into mamba-org:main Aug 11, 2022
@fcollonval fcollonval deleted the ft/add-jupyter-releaser branch August 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance and upkeep improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants