Create empty base prefix with env update
#3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hind-M
commented
Oct 9, 2024
micromamba/tests/test_env.py
Outdated
| @@ -307,6 +307,7 @@ def test_env_update_conda_forge_with_pypi(tmp_home, tmp_root_prefix, tmp_path): | |||
| channels: | |||
| - conda-forge | |||
| dependencies: | |||
| - python 3.10 | |||
There was a problem hiding this comment.
This is to fix the CI test failure due to some known issues with python 3.11 and pip.
There was a problem hiding this comment.
I think that it can now be removed since #3537 has been merged.
Hind-M
commented
Oct 9, 2024
| """ | ||
|
|
||
|
|
||
| def test_install_empty_base(tmp_home, tmp_root_prefix, tmp_path): |
There was a problem hiding this comment.
Such a test was missing, i.e test creation of a valid environment with install when target prefix is the root prefix.
jjerphan
approved these changes
Oct 16, 2024
micromamba/tests/test_env.py
Outdated
| @@ -307,6 +307,7 @@ def test_env_update_conda_forge_with_pypi(tmp_home, tmp_root_prefix, tmp_path): | |||
| channels: | |||
| - conda-forge | |||
| dependencies: | |||
| - python 3.10 | |||
There was a problem hiding this comment.
I think that it can now be removed since #3537 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3515