Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failure on win-64 #3315

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Fix CI failure on win-64 #3315

merged 2 commits into from
Jun 11, 2024

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Jun 10, 2024 •
edited
Loading

@Hind-M Hind-M added release::bug_fixes For PRs fixing bugs release::ci_docs For PRs related to CI or documentation and removed release::bug_fixes For PRs fixing bugs labels Jun 10, 2024
@Hind-M Hind-M marked this pull request as ready for review June 10, 2024 10:28
@Hind-M Hind-M requested review from Klaim and JohanMabille June 10, 2024 13:11
Klaim
Klaim approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad we have to disable such thing, but I guess that's temporary. LGTM!

JohanMabille
JohanMabille reviewed Jun 10, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@JohanMabille JohanMabille merged commit 49fd2f0 into mamba-org:main Jun 11, 2024
32 checks passed
@Hind-M Hind-M deleted the fix_win_ci branch June 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@Klaim Klaim Klaim approved these changes

Assignees
No one assigned
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hind-M @Klaim @JohanMabille