Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config precedence for base env #3009

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented Nov 24, 2023

closes #2704

Co-authored-by: Daniel Elsner <daniel.elsner@quantco.com>
@jonashaag
Copy link
Contributor

Can you please add a test if possible?

As the rc_files option is only a configurable size, only the first occurrence of each value is retained, which corresponds to the occurrence with the highest precedence. Deduplication is therefore no longer possible afterwards.
@0xbe7a
Copy link
Contributor Author

0xbe7a commented Nov 27, 2023

@jonashaag or @AntoinePrv, can you enable the workflows?

Copy link
Contributor

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@jonashaag jonashaag merged commit 7f325df into mamba-org:main Nov 27, 2023
27 checks passed
@0xbe7a 0xbe7a deleted the fix-config-precedence branch November 27, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mamba / Micromamba uses incorrect channel_alias when base env is active
2 participants