Backport: Further improve search output (#2823) #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delsner
commented
Nov 23, 2023
| entry.second[0], | ||
| std::vector(entry.second.begin() + 1, entry.second.end()) | ||
| std::vector(entry.second.begin() + 1, entry.second.end()), | ||
| Context::instance().output_params.verbosity > 0 |
There was a problem hiding this comment.
This is a slight difference to the original patch #2823; since the context singleton isn't available in the entrypoint in libmamapy yet, we're retrieving the context singleton here directly.
jonashaag
force-pushed
the
backport-search-improvements
branch
from
dcd5990 to
d5ce764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports patch #2823 to 1.x in order to address #3005.