Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse remote_connect_timeout_secs as a double #2949

Merged
merged 4 commits into from
Oct 30, 2023
Merged

fix: Parse remote_connect_timeout_secs as a double #2949

merged 4 commits into from
Oct 30, 2023

Conversation

jjerphan
Copy link
Member

Fix #2934.

@jjerphan
fix: Parse remote_connect_timeout_secs as a double
707dd19 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
test: Test parsing of .condarc
d20689b 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
fixup! test: Test parsing of .condarc
4e7b54f
@jjerphan
lint: Format .condarc
93fb0a6 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan marked this pull request as ready for review October 30, 2023 10:52
@AntoinePrv
Copy link
Member

@jjerphan how easy would it be to backport to 1.x branch?

@jjerphan
Copy link
Member Author

Easy, just a few .pyi files to change.

@AntoinePrv AntoinePrv merged commit cab1bbf into mamba-org:main Oct 30, 2023
18 checks passed
@jjerphan jjerphan deleted the fix/2934 branch October 30, 2023 12:46
@jjerphan jjerphan mentioned this pull request Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@AntoinePrv AntoinePrv AntoinePrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Micromamba does not parse remote_connect_timeout_secs in condarc correctly
3 participants
@jjerphan @AntoinePrv @JohanMabille