Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PackageFetcher #2917

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Added PackageFetcher #2917

merged 4 commits into from
Oct 19, 2023

Conversation

JohanMabille
Copy link
Member

No description provided.

@JohanMabille JohanMabille force-pushed the download branch 3 times, most recently from b814b50 to cea96ed Compare October 17, 2023 20:45
Klaim
Klaim reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review, mostly nitpicking.

libmamba/include/mamba/core/download_progress_bar.hpp Show resolved Hide resolved
libmamba/include/mamba/core/package_fetcher.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/core/package_fetcher.hpp Outdated Show resolved Hide resolved
libmamba/src/core/download.cpp Outdated Show resolved Hide resolved
libmamba/src/core/download.cpp Outdated Show resolved Hide resolved
libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved
libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved
libmamba/src/core/transaction.cpp Show resolved Hide resolved
libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved
libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved
@JohanMabille JohanMabille requested a review from Klaim October 18, 2023 19:14
Klaim
Klaim approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvs (and a question) listed otherwise LGTM

libmamba/src/core/package_fetcher.cpp Outdated Show resolved Hide resolved
libmamba/src/core/package_fetcher.cpp Outdated Show resolved Hide resolved
libmamba/src/core/package_fetcher.cpp Outdated Show resolved Hide resolved
libmamba/src/core/transaction.cpp Show resolved Hide resolved
libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved
@JohanMabille JohanMabille merged commit 00dd002 into mamba-org:main Oct 19, 2023
@JohanMabille JohanMabille deleted the download branch October 19, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim approved these changes

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohanMabille @Klaim @SylvainCorlay