Resolve ChannelSpec into a Channel #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Oct 9, 2023
•
AntoinePrv
commented
- Based on Add ChannelSpec #2870
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
9 times, most recently
from
17a0de9 to
0ad5a7f
Compare
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
10 times, most recently
from
52ce5c0 to
a4fcad6
Compare
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
3 times, most recently
from
8c25cdf to
e002468
Compare
This is disbled as TUF implementation is not well defined and this function is not used except in experimental conditions.
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
from
56877d7 to
c98210a
Compare
|
|
||
| #ifndef MAMBA_UTIL_TUPLE_HASH_HPP | ||
| #define MAMBA_UTIL_TUPLE_HASH_HPP | ||
|
|
There was a problem hiding this comment.
Do we want this file to be part of the public API of libmamba?
There was a problem hiding this comment.
I guess this discussion applies to a lot of the util library. We currently do not have a good way to both separate public/private headers and organize it by topic (util/specs/...).
| { | ||
| base = util::join_url(base, "t", *token()); | ||
| return {}; |
There was a problem hiding this comment.
Is an empty set expected in that case?
There was a problem hiding this comment.
Yes. At least that is what I am aiming for. When specifiying a full URL to a package https://mamba.org/somthing/pkg.conda I am not assuming any repo/channel structure.
In the future, I'd like to better separate these two cases.
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
2 times, most recently
from
440c423 to
6f207b2
Compare
AntoinePrv
force-pushed
the
channel-spec-resolve
branch
from
6f207b2 to
6131728
Compare
JohanMabille
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.