Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build micromamba win with feedstock #2859

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Conversation

AntoinePrv
Copy link
Member

No description provided.

@AntoinePrv AntoinePrv marked this pull request as ready for review September 21, 2023 09:50
@AntoinePrv AntoinePrv marked this pull request as draft September 21, 2023 09:51
@AntoinePrv
Copy link
Member Author

AntoinePrv commented Sep 21, 2023

@pavelzw any idea how to get the "Micromamba static builds" started?

@pavelzw
Copy link
Member

pavelzw commented Sep 21, 2023

My suggestion would be to use only vcpkg for static builds and avoid going through the pain of static builds with conda-build for windows 😅

The static builds with only vcpkg have cause way fewer issues than trying with conda-build. I don't see the value of trying to port this to conda-build.

Personally, I would just leave the static CI with windows be and try to migrate the release workflow to actually use this build instead of the conda-forge static binaries as discussed in #2595.

@AntoinePrv
Copy link
Member Author

This is not DRY, we need to sync the feedstock and this CI constantly. VCPKG has caused a lot of outages too. Conda-Forge takes more pain to setup I agree but once it is setup it's stable and simple, no need for extra cache etc. We also need to work with two systems, which is not convenient, because were are not gonna stop shipping libmambapy.

@pavelzw
Copy link
Member

pavelzw commented Sep 21, 2023

But how about trying to get rid of the vcpkg dependency in the recipe first? You already did the (hopefully 😅) most painful part by moving the libsolv dependency to conda-forge.

@AntoinePrv
Copy link
Member Author

Fair enough. How about trying adding a light environment and starting to also used the libs that are properly packaged statically?

@AntoinePrv AntoinePrv force-pushed the win-static branch 5 times, most recently from 98e8adc to a4e7a1d Compare September 25, 2023 16:14
@AntoinePrv
Copy link
Member Author

Great this seems to be working. The point is I am adding some more dependencies and don't want to do the work twice.

@pavelzw

  • Do you know if these are deployed anywhere? If so I might be more reluctant to do mixed builds here (but I would also encourage to take the builds from conda-forge).
  • Can we remove entries from vcpkg.json, or should we keep that file complete because it is used elsewhere?

@AntoinePrv AntoinePrv changed the title Try building micromamba win with feedstock Build micromamba win with feedstock Sep 27, 2023
@AntoinePrv AntoinePrv marked this pull request as ready for review September 27, 2023 07:48
@AntoinePrv
Copy link
Member Author

Being pragmatic, this is the easiest way to fix the CI and discrepancies between yaml-cpp packages.

@AntoinePrv AntoinePrv merged commit be30af6 into mamba-org:main Sep 27, 2023
@AntoinePrv AntoinePrv deleted the win-static branch September 27, 2023 08:32
JohanMabille pushed a commit that referenced this pull request Oct 16, 2023
* Try CI

* Remove useless header

* Try mixing static windows build with Conda

* More packages from conda-forge

* Move to yaml-cpp>=0.8.0

* Ensure proper yaml-cpp target

* Use yaml-cpp-static on Windows

* Fix versions

* Use libsolv-static from Conda-Forge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants