-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic_string for path on Windows unix shells #2685
Conversation
Can we add a test for this? |
Hmm, bash should already be tested on Windows so it is weird that we had a bug to start with... |
I tested it on cygwin:
Unfortunately, it still uses the windows paths. (got the executable from this commit 0xbe7a@32846b1) |
f47bfb3
to
73b0f54
Compare
Just tried it with a brand-new windows server instance with cygwin installed. There, it still uses the windows paths.
I used the executable from |
73b0f54
to
3e538b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this but worry that the paths displayed might be misleading to users. Maybe displaying both on windows would be best?
@Klaim there is no displaying in this PR. This are activation scripts being run when using |
Ok I thought these paths were also displayed when doing |
Let's give it a try |
Fix #2683