Try fixing missing subdirs on mamba.py #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Jun 28, 2023
AntoinePrv
commented
- Use install repo from libmamba in mamba.py
- Regenerate stubgens
Hind-M
approved these changes
Jun 29, 2023
| @@ -807,6 +807,7 @@ PYBIND11_MODULE(bindings, m) | |||
| .def_readwrite("version", &PackageInfo::version) | |||
| .def_readwrite("build_string", &PackageInfo::build_string) | |||
| .def_readwrite("build_number", &PackageInfo::build_number) | |||
| .def_readwrite("noarch", &PackageInfo::noarch) | |||
There was a problem hiding this comment.
I don't know how important the noarch could be, but it seems to be missing in some of the PackageInfo methods compared to the other members. So maybe we should add it there as well? (for consistency and comprehensiveness).
There was a problem hiding this comment.
Noarch is definitely important. Where do you see it missing?
There was a problem hiding this comment.
In build_field_getter_map ,json_record and json_signable for example?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.