Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ObjSolver wrapper in MSolver #2602

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Use ObjSolver wrapper in MSolver #2602

merged 5 commits into from
Jun 20, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Jun 19, 2023 •
edited
Loading

  • Add control in solv-cpp
  • Use ObjSolver in MSolver::reinstall_job
  • Document weird libsolv side effects
  • Change MSolver::add_pin to use wrappers

@AntoinePrv AntoinePrv changed the title Use ObjSolver wrapper in MSolver" Use ObjSolver wrapper in MSolver Jun 19, 2023
@AntoinePrv AntoinePrv mentioned this pull request Jun 19, 2023
Merged
1 task
@AntoinePrv AntoinePrv self-assigned this Jun 19, 2023
Hind-M
Hind-M approved these changes Jun 19, 2023
View reviewed changes
libmamba/tests/src/solv-cpp/test_pool.cpp Outdated Show resolved Hide resolved
@AntoinePrv @Hind-M
Update libmamba/tests/src/solv-cpp/test_pool.cpp
0e858b1 
Co-authored-by: Hind-M <70631848+Hind-M@users.noreply.github.com>
@JohanMabille JohanMabille merged commit 30235ee into mamba-org:main Jun 20, 2023
@AntoinePrv AntoinePrv deleted the solv-use-solver branch June 20, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hind-M Hind-M Hind-M approved these changes

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees

@AntoinePrv AntoinePrv

Labels
type::refactoring where::libsolv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoinePrv @JohanMabille @Hind-M