Split the transaction.hpp header #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AntoinePrv
force-pushed
the
solv-split-transaction
branch
from
21c0b6d to
638cec4
Compare
Klaim
approved these changes
Jun 9, 2023
|
|
||
| DownloadTarget* target(MultiPackageCache& cache); | ||
|
|
||
| std::exception m_decompress_exception; |
There was a problem hiding this comment.
BTW do you know what this object is and why it's public?
There was a problem hiding this comment.
I have not yet worked with that code.
M guess is catching the exception is thread to rethrow in the main one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mechanical split, no other changes.