Channels refactoring/cleaning #2537

Hind-M · 2023-05-22T10:15:02Z

No description provided.

libmamba/src/core/subdirdata.cpp

libmamba/include/mamba/core/util_url.hpp

Hind-M self-assigned this May 22, 2023

Hind-M added type::general-improvement type::refactoring labels May 22, 2023

Hind-M force-pushed the chan_refactor branch from f3217c8 to 1ec6a85 Compare May 24, 2023 09:34

Hind-M force-pushed the chan_refactor branch from 5ae93bc to 5a84f0f Compare June 7, 2023 09:27

Hind-M commented Jun 8, 2023

View reviewed changes

libmamba/src/core/subdirdata.cpp Show resolved Hide resolved

Hind-M force-pushed the chan_refactor branch 2 times, most recently from 68aee8f to b3f31ea Compare June 12, 2023 07:57

Hind-M marked this pull request as ready for review June 12, 2023 15:05

Hind-M marked this pull request as draft June 13, 2023 09:51

Remove unused functions

27533c3

Hind-M force-pushed the chan_refactor branch from b3f31ea to 2156a7a Compare June 14, 2023 08:24

Hind-M added 7 commits June 14, 2023 10:39

Have make_channel and parsing in different lines

6c779d1

Remove m_canonical_name setting in getter

0c8be0c

Set canonical_name in make_simple_channel and make it mandatory

a2a4bc4

Fix canonical_name setting

7833668

Remove make_cached_channel

14c6315

Remove channel_context from channel

cf3e1d4

Cleaning and moving functions around and add some tests

5089342

Hind-M force-pushed the chan_refactor branch from 2156a7a to 5089342 Compare June 14, 2023 08:40

Add forgotten mamba namespace in tests

41b21e0

Hind-M marked this pull request as ready for review June 14, 2023 11:06

Hind-M requested a review from JohanMabille June 14, 2023 11:06

JohanMabille reviewed Jun 20, 2023

View reviewed changes

libmamba/include/mamba/core/util_url.hpp Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into chan_refactor

2af1d33

Hind-M mentioned this pull request Jun 21, 2023

Wrap curl functions in url files #2611

Closed

Hind-M and others added 2 commits June 22, 2023 18:13

Move utility functions to url files and remove util_url

dc94a33

Merge branch 'main' into chan_refactor

750a62b

JohanMabille approved these changes Jun 28, 2023

View reviewed changes

JohanMabille merged commit 1b28840 into mamba-org:main Jun 28, 2023

Hind-M deleted the chan_refactor branch June 28, 2023 11:22

riccardoporreca mentioned this pull request Jul 9, 2023

Issue with fake_conda_environment and mamba >= 1.4.6 conda/conda-lock#452

Closed

2 tasks

Provide feedback