fix: Improve message after the env creating with micromamba #2425

xmnlab · 2023-03-29T17:51:40Z

This PR aims to improve the message presented after the environment creation with micromamba.

xmnlab · 2023-03-29T17:53:45Z

note: I made some changes in the environment files, and gitignore because it was something that popped-up locally .. let me know if it is ok to keep that changes, otherwise I am also glad to remove that here.

thanks!

xmnlab · 2023-03-29T17:55:29Z

btw, I opened this PR in draft mode just to get some inputs/reviews in early stage ... I am checking now how to get the environment name to add it to the message.

but if anyone could give some tips it would be very appreciated :)

xmnlab · 2023-03-29T19:21:19Z

just for the record, this is how the output looks like:

...
Linking wheel-0.40.0-pyhd8ed1ab_0
Linking setuptools-67.6.1-pyhd8ed1ab_0
Linking pip-23.0.1-pyhd8ed1ab_0

Transaction finished

To activate this environment, use:

    $ micromamba activate <placeholder>

Or to execute a single command in this environment,  use:

    $ micromamba run -n <placeholder> mycommand

(mamba-dev) ✔ ~/dev/prefixdev-projects/mamba

AntoinePrv

Thanks for the suggestion!

This files and the IO mechanism will go through a redesign.
I'm OK to add this with [micro]mamba and <environment> for now so that we know to add it in the refactoring.
Perhaps leave a comment //TODO add executable name TODO add environment name/prefix.

AntoinePrv · 2023-03-30T14:18:29Z

.gitignore

+libmamba/Makefile
+libmamba/libmambaConfig.cmake
+libmamba/libmambaConfigVersion.cmake
+libmamba/libmambaTargets.cmake
+sometestfile.txt


Let's leave this out o this PR. We do use cmake -B build/ to have the CMake generated files separate in the build/ direcrtory.
Then you can cmake --build build/ ...

AntoinePrv · 2023-03-30T14:19:14Z

libmamba/environment-static-dev.yml

@@ -3,7 +3,7 @@ channels:
  - conda-forge
 dependencies:
  - cxx-compiler
-  - cmake
+  - cmake >=3.16


I'm OK with this, it's the one specified in CMakeLists.txt

AntoinePrv · 2023-03-30T14:21:56Z

libmamba/src/core/transaction.cpp

+            Console::stream() << "\nTransaction finished";
+            Console::stream() << "\nTo activate this environment, use:\n";
+            Console::stream() << "    $ micromamba activate <placeholder>";
+            Console::stream() << "\nOr to execute a single command in this environment,  use:\n";
+            Console::stream() << "    $ micromamba run -n <placeholder> mycommand\n";


You can log that in a single string.

xmnlab · 2023-03-30T15:06:51Z

thanks for the review @AntoinePrv , appreciate that!
I will apply all the suggestions soon! thanks

xmnlab · 2023-03-31T01:10:51Z

@AntoinePrv, I already applied the changes you requested.
thank you so much for your review

Hind-M · 2023-03-31T09:09:05Z

Thanks for this PR!
To avoid the linters failure on the CI, you can run pre-commit run --all locally :)

xmnlab · 2023-03-31T12:48:25Z

pre-commit run --all

oh nice! I missed that! thank you so much for the tip! I will install the pre-commit hooks here! thanks!

AntoinePrv · 2023-03-31T12:50:50Z

@xmnlab already done for you :)
Current CI failures seems unrelated.

xmnlab · 2023-03-31T12:57:17Z

@AntoinePrv thank you so much! I will take a look into that in a bit :)

xmnlab · 2023-03-31T13:38:33Z

@AntoinePrv thank you so much for your review! and all the help :)
I just rebased my branch in order to have the CI running with the last changes.

let me know if there is anything else I can do about this PR :)

thanks!

ocefpaf · 2023-05-18T17:10:39Z

libmamba/src/core/transaction.cpp

+                              << "To activate this environment, use:\n\n"
+                              << "    $ [micro]mamba activate <environment>\n\n"
+                              << "Or to execute a single command in this environment, use:\n\n"
+                              << "    $ [micro]mamba run -n <environment> mycommand\n";


This message is being triggered in all transactions, install, update, etc, and not only environment creation. It is a bit noisy that way b/c for most of those the user is already in the environment and defeats the purposes of the message.

PS: It would be nice to change the <environment> for the actual name of the environment, mimicking conda's behavior and making the message "copy-n-pastable."

This message is being triggered in all transactions, install, update, etc, and not only environment creation. It is a bit noisy that way b/c for most of those the user is already in the environment and defeats the purposes of the message.

Hmm I agree!

PS: It would be nice to change the <environment> for the actual name of the environment, mimicking conda's behavior and making the message "copy-n-pastable."

It's already the case on the last version of the code :)

It's already the case on the last version of the code :)

Awesome. Waiting for the new release.

xmnlab force-pushed the add-message-for-activation branch from b2d8ef2 to de76d2d Compare March 29, 2023 17:52

AntoinePrv reviewed Mar 30, 2023

View reviewed changes

xmnlab force-pushed the add-message-for-activation branch from 5a5bbfb to 960dc5e Compare March 31, 2023 01:07

xmnlab marked this pull request as ready for review March 31, 2023 01:09

AntoinePrv approved these changes Mar 31, 2023

View reviewed changes

xmnlab force-pushed the add-message-for-activation branch from b99d5ce to 7845838 Compare March 31, 2023 13:29

xmnlab and others added 4 commits March 31, 2023 17:24

fix: Improve message after the env creating

e91296d

Add more new lines

ad90962

Add suggestions from review

2724fa7

fmt: apply clang-format

5d71f6d

AntoinePrv force-pushed the add-message-for-activation branch from 7845838 to 5d71f6d Compare March 31, 2023 15:24

AntoinePrv merged commit a3597e3 into mamba-org:main Mar 31, 2023

ocefpaf reviewed May 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Improve message after the env creating with micromamba #2425

fix: Improve message after the env creating with micromamba #2425

xmnlab commented Mar 29, 2023 •

edited

Loading

xmnlab commented Mar 29, 2023

xmnlab commented Mar 29, 2023

xmnlab commented Mar 29, 2023

AntoinePrv left a comment

AntoinePrv Mar 30, 2023

AntoinePrv Mar 30, 2023

AntoinePrv Mar 30, 2023

xmnlab commented Mar 30, 2023

xmnlab commented Mar 31, 2023

Hind-M commented Mar 31, 2023

xmnlab commented Mar 31, 2023

AntoinePrv commented Mar 31, 2023 •

edited

Loading

xmnlab commented Mar 31, 2023

xmnlab commented Mar 31, 2023

ocefpaf May 18, 2023

Hind-M May 19, 2023

ocefpaf May 19, 2023

fix: Improve message after the env creating with micromamba #2425

fix: Improve message after the env creating with micromamba #2425

Conversation

xmnlab commented Mar 29, 2023 • edited Loading

xmnlab commented Mar 29, 2023

xmnlab commented Mar 29, 2023

xmnlab commented Mar 29, 2023

AntoinePrv left a comment

Choose a reason for hiding this comment

AntoinePrv Mar 30, 2023

Choose a reason for hiding this comment

AntoinePrv Mar 30, 2023

Choose a reason for hiding this comment

AntoinePrv Mar 30, 2023

Choose a reason for hiding this comment

xmnlab commented Mar 30, 2023

xmnlab commented Mar 31, 2023

Hind-M commented Mar 31, 2023

xmnlab commented Mar 31, 2023

AntoinePrv commented Mar 31, 2023 • edited Loading

xmnlab commented Mar 31, 2023

xmnlab commented Mar 31, 2023

ocefpaf May 18, 2023

Choose a reason for hiding this comment

Hind-M May 19, 2023

Choose a reason for hiding this comment

ocefpaf May 19, 2023

Choose a reason for hiding this comment

xmnlab commented Mar 29, 2023 •

edited

Loading

AntoinePrv commented Mar 31, 2023 •

edited

Loading