No Storing Channel* and MRepo* in Solvables #2409
Conversation
AntoinePrv
force-pushed
the
solv-repo-url
branch
2 times, most recently
from
0dea571 to
e57b81e
Compare
AntoinePrv
force-pushed
the
solv-repo-url
branch
from
e57b81e to
547abdb
Compare
AntoinePrv
requested review from
JohanMabille and
wolfv
and removed request for
JohanMabille
| m_real_repo_key = pool_str2id(pool, "solvable:real_repo_url", 1); | ||
| m_mrepo_key = pool_str2id(pool, "solvable:mrepo_url", 1); |
There was a problem hiding this comment.
What is the difference between repo and real_repo ?
There was a problem hiding this comment.
I'd like to know too! This is a mechanical operation that stores the value of MRepo::url for retrival.
I tried to merge real_repo_url and mrepo_url but it was significantly more tricky than the scope of this PR.
There was a problem hiding this comment.
There is also m_metadata.url/"mamba:url" in the mix
| @@ -165,6 +165,8 @@ namespace mamba | |||
|
|
|||
| History::UserRequest m_history_entry; | |||
| Transaction* m_transaction; | |||
| ::Id m_real_repo_key = 0; // Must match that in ``MRepo`` | |||
| ::Id m_mrepo_key = 0; // Must match that in ``MRepo`` | |||
There was a problem hiding this comment.
I guess this leaking of libsolv details in the transaction class is temporary and will be replaced with PackageInfo list on the long run? In the meantime, they (and those in MRepo) should call the same initialization function to ensure their "synchronization"
There was a problem hiding this comment.
This constraint was already here, the PR just made it more obvious.
At the libsolv level (which will be private), #2401 will introduce clean getter/setter in the bindings so that we don't need to match the keys manually.
At the user level, this will be invisible. The user will only deal in PackageInfo style of data.
This removes
mamba::Channel*inmamba::MRepomamba::MRepo*in::Repo::appdatamamba::MRepoandmamba::Channel