DependencyInfo is redundant #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
commented
Feb 21, 2023
| @@ -34,7 +34,7 @@ namespace mamba | |||
| std::string channel; | |||
| std::string ns; | |||
| std::string subdir; | |||
| std::string build; | |||
| std::string build_string; | |||
There was a problem hiding this comment.
API change in MatchSpec here.
wolfv
approved these changes
Feb 22, 2023
|
Looks good to me! :) |
AntoinePrv
force-pushed
the
sat-error
branch
from
ae3c890 to
b7d45e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatchSpec::build>MatchSpec::build_stringfor consistency and ease of use in the SAT error messages.vector_setas done instd::setDependencyInfo