-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove banner #2298
Remove banner #2298
Conversation
Shouldn't we fix the remaining bugs to guarantee that users can remove the banner if they want? Or even have it not displayed by default, but not entirely removed? |
My take is that most users don't want the banner. Why would you want a banner? |
@JohanMabille @AntoinePrv @Klaim @wolfv shall we remove the banners? |
I have no objection to removing the banner. I'm already removing it in my |
I have no objection either. |
2fd7f7e
to
a5bb46a
Compare
Hi all, I'm going to merge this this week if I don't hear any further feedback :) |
How about making the final call tomorrow (Tuesday June 20th 2023) during the mamba meeting? |
I can't join tomorrow but feel free to make a decision :) |
Sorry for the late reply, I have no objection to removing the banner. |
@jonashaag Just for clarification: Does this PR mean there's no more banner in any shape or form in neither mamba nor micromamba from 1.4.5 onwards? 🙏 I just spent 10 minutes figuring out how to remove the banner after switching to micromamba where my previous environment file solution didn't work anymore. |
Yes! |
I know this is a controversial proposal :-)
Related issues (some we have fixed already)
-q
if-q
is passed #2089