Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[micromamba] Stop run command when given prefix does not exist #2257

Merged
merged 3 commits into from
Feb 2, 2023
Merged

[micromamba] Stop run command when given prefix does not exist #2257

merged 3 commits into from
Feb 2, 2023

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Feb 1, 2023

Fix #2084
The exception thrown during env activation is indeed not caught. Since reproc has the upper hand and doesn't catch it, I added a check at the beginning of run_in_environment function.

@Hind-M Hind-M requested a review from jonashaag February 1, 2023 10:53
@jonashaag
Copy link
Contributor

LGTM, can you please add a test?

@Hind-M
Copy link
Member Author

Hind-M commented Feb 1, 2023

LGTM, can you please add a test?

Done!

jonashaag
jonashaag approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are the test failures related?

@Hind-M
Copy link
Member Author

Hind-M commented Feb 2, 2023 •
edited
Loading

Are the test failures related?

I don't think so because I get the same failures in another PR, but not sure enough.
@wolf @Klaim are the test failures related to something specific?

@jonashaag
Copy link
Contributor

Ah, it's because of .tar.bz2 -> .conda

@jonashaag
Copy link
Contributor

See #2258

@jonashaag jonashaag merged commit 353ed8d into mamba-org:main Feb 2, 2023
@Hind-M Hind-M deleted the fix_run branch February 2, 2023 14:29
@jonashaag jonashaag mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonashaag jonashaag jonashaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

micromamba run with missing env still attempts to execute the command
2 participants
@Hind-M @jonashaag