No .solv files on Windows (slow)

libmamba/src/core/repo.cpp

@@ -30,6 +30,7 @@ extern "C"  // Incomplete header
 #include "mamba/core/prefix_data.hpp"
 #include "mamba/core/repo.hpp"
 #include "mamba/core/util.hpp"
+#include "mamba/util/build.hpp"
 #include "mamba/util/string.hpp"
 #include "mamba/util/url_manip.hpp"
 #include "solv-cpp/pool.hpp"
@@ -533,21 +534,15 @@ namespace mamba
         bool is_solv = filename.extension() == ".solv";
 
         fs::u8path solv_file = filename;
+        solv_file.replace_extension("solv");
         fs::u8path json_file = filename;
-
-        if (is_solv)
-        {
-            json_file.replace_extension("json");
-        }
-        else
-        {
-            solv_file.replace_extension("solv");
-        }
+        json_file.replace_extension("json");
 
         LOG_INFO << "Reading cache files '" << (filename.parent_path() / filename).string()
                  << ".*' for repo index '" << name() << "'";
 
-        if (is_solv && (use_cache == LibsolvCache::yes))
+        // .solv files are slower to load than simdjson on Windows
+        if (!util::on_win && is_solv && (use_cache == LibsolvCache::yes))
         {
             const auto lock = LockFile(solv_file);
             const bool read = read_solv(solv_file);
@@ -570,6 +565,7 @@ namespace mamba
             else
             {
                 libsolv_read_json(json_file);
+                set_solvables_url(repo, m_metadata.url);
             }
         }
 
@@ -579,11 +575,10 @@ namespace mamba
             add_pip_as_python_dependency();
         }
 
-        if (name() != "installed")
+        if (!util::on_win && (name() != "installed"))
         {
             write_solv(solv_file);
         }
-        set_solvables_url(repo, m_metadata.url);
     }
 
     void MRepo::write_solv(fs::u8path filename)

micromamba/tests/test_pkg_cache.py

@@ -1,4 +1,5 @@
 import os
+import platform
 import shutil
 import subprocess
 from pathlib import Path
@@ -345,7 +346,8 @@ def test_first_writable_extracted_dir_corrupted(
         # check repodata files
         assert repodata_json(tmp_cache) == set()
         assert repodata_json(tmp_cache_alt) != set()
-        assert same_repodata_json_solv(tmp_cache_alt)
+        if platform.system() != "Windows":  # No .solv on Windows
+            assert same_repodata_json_solv(tmp_cache_alt)
 
         # check tarballs
         assert find_cache_archive(tmp_cache, xtensor_bld) is None
@@ -385,7 +387,8 @@ def test_extracted_tarball_only_in_non_writable_cache(
 
         # check repodata files
         assert repodata_json(tmp_cache) != set()
-        assert same_repodata_json_solv(tmp_cache)
+        if platform.system() != "Windows":  # No .solv on Windows
+            assert same_repodata_json_solv(tmp_cache)
         assert repodata_json(tmp_cache_alt) == set()
 
         # check tarballs
@@ -424,7 +427,8 @@ def test_missing_extracted_dir_in_non_writable_cache(
 
         # check repodata files
         assert repodata_json(tmp_cache) != set()
-        assert same_repodata_json_solv(tmp_cache)
+        if platform.system() != "Windows":  # No .solv on Windows
+            assert same_repodata_json_solv(tmp_cache)
         assert repodata_json(tmp_cache_alt) == set()
 
         # check tarballs
@@ -458,7 +462,8 @@ def test_corrupted_extracted_dir_in_non_writable_cache(
 
         # check repodata files
         assert repodata_json(tmp_cache) != set()
-        assert same_repodata_json_solv(tmp_cache)
+        if platform.system() != "Windows":  # No .solv on Windows
+            assert same_repodata_json_solv(tmp_cache)
         assert repodata_json(tmp_cache_alt) == set()
 
         # check tarballs
@@ -505,9 +510,11 @@ def test_expired_but_valid_repodata_in_non_writable_cache(
 
         # check repodata files
         assert repodata_json(tmp_cache) != set()
-        assert same_repodata_json_solv(tmp_cache)
+        if platform.system() != "Windows":  # No .solv on Windows
+            assert same_repodata_json_solv(tmp_cache)
         assert repodata_json(tmp_cache_alt) != set()
-        assert same_repodata_json_solv(tmp_cache_alt)
+        if platform.system() != "Windows":  # No .solv on Windows
+            assert same_repodata_json_solv(tmp_cache_alt)
 
         # check tarballs
         assert find_cache_archive(tmp_cache, xtensor_bld).exists()