Classic notebook extension with 2.0.0 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 394423428
💛 - Coveralls |
|
Thanks @fcollonval, tested on Binder and it looks good 👍 |
jtpio
reviewed
Dec 2, 2020
Comment on lines
+44
to
+47
| os.path.join(classic_folder, "static", a_file) | ||
| for a_file in os.listdir(os.path.join(classic_folder, "static")) | ||
| if os.path.isfile(os.path.join(classic_folder, "static", a_file)) | ||
| and not a_file.endswith(".py") |
There was a problem hiding this comment.
Wondering if this could be handled with a glob pattern, that would exclude .py files. Globs should be supported by jupyter-packaging if we end up switching to it in the near future (for example when updating to lab 3.0).
There was a problem hiding this comment.
It might also make it easier to handle nested folders in static (if any)
jtpio
approved these changes
Dec 3, 2020
|
Looks like the Windows failure is not relevant, but was also present in the previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115