Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autoActivate argument #21

Merged
merged 3 commits into from
Jul 3, 2023
Merged

add autoActivate argument #21

merged 3 commits into from
Jul 3, 2023

Conversation

li-yq
Copy link
Contributor

@li-yq li-yq commented Jul 3, 2023

Added an autoActivate argument so that auto activation of the base environment can be manually disabled.

eitsupi
eitsupi reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Could you bump the minor version in the json file?

src/micromamba/devcontainer-feature.json Show resolved Hide resolved
@eitsupi eitsupi requested a review from maresb July 3, 2023 09:40
eitsupi
eitsupi approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

maresb
maresb approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks great, thanks a lot for the contribution!

@maresb maresb merged commit 745a0dd into mamba-org:main Jul 3, 2023
10 checks passed
@eitsupi
Copy link
Member

eitsupi commented Jul 3, 2023

The new version was released. 🎉
https://github.com/mamba-org/devcontainer-features/pkgs/container/devcontainer-features%2Fmicromamba/106515421?tag=1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maresb maresb maresb approved these changes

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@li-yq @eitsupi @maresb