-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for conda/conda-build deprecations #395
Update for conda/conda-build deprecations #395
Conversation
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
76ebc17
to
d6eae80
Compare
conda._vendor.boltons has been marked for deprecation in conda=23.3 and will be removed in conda=23.4. refs: - https://github.com/conda/conda/pull/12453/files Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
95fd1b8
to
b6572ec
Compare
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
8e23ad8
to
689bf8e
Compare
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
refs: - conda/conda-build#5222 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L15 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L95 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L104 - https://github.com/conda/conda-build/blob/24.1.2/conda_build/conda_interface.py#L114 - https://github.com/conda/conda/blob/24.1.2/conda/utils.py#L235 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
ref: - conda/conda-build#5184 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
Fixes mamba-org#388 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
689bf8e
to
1aa8d1f
Compare
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@@ -149,7 +149,7 @@ def get_value(self, in_key: str, default: Any = None, autotype=True) -> Any: | |||
if autotype and default is None and FIELDS.get(section, {}).get(key): | |||
default = FIELDS[section][key]() | |||
|
|||
section = self.output.sections.get(section, {}) | |||
section = self.meta.get(section, {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused gh-388 since .get_value
is called from conda-build
code which expects return types from original conda_build.metadata.MetaData
(e.g., str
, not CondaBuildSpec
).
From a quick glance, I couldn't make out any calls from within boa
that expect boa
-specific types here; would be good to have another pair of eyes confirming this..
cc @SylvainCorlay (for awareness) |
Terrific job, thanks! |
Nice. Thank you @mbargull |
Thanks all! 🙏 Think we will want a release with these changes as well. Not sure what the process is there |
Just made a PR @jakirkham #396 |
This updates
boa
for compatibility with current/upcomingconda-build
versions.Overview:
conda
/conda-build
pre-release versions.boltons
dependency sinceconda._vendor.boltons
is being removed.conda-build
to3.25
(semi-arbitrarily chosen;>=3.25
include, e.g., fixes for downstream tests).conda_build.conda_interface
.