Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'copy' button, use translations for buttons #8

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

Dominic-Marcelino
Copy link
Contributor

Thanks for the great module! Makes developing in TS way more convenient.

Personally I don't like to always download a new type-declaration file. Once I have an existing types-file I prefer copy-pasting the content into it.
Therefore I've added a copy button to the components.

Next to it I've used the default app translations for the button texts.

@Dominic-Marcelino
Copy link
Contributor Author

Bildschirmfoto 2022-09-05 um 12 58 46

@maltejur
Copy link
Owner

maltejur commented Sep 5, 2022

Thanks! Looks good and the code is clean.

@maltejur maltejur merged commit bc7ab7b into maltejur:master Sep 5, 2022
@Dominic-Marcelino
Copy link
Contributor Author

Thanks! Looks good and the code is clean.

Thanks!

Just as an information:
The use-clipboard composable is more or less a copy of the app ones: https://github.com/directus/directus/blob/main/app/src/composables/use-clipboard.ts

If they move the app components and composables into an own packages one day (from what I heard they're working on it), the included copy could be removed in favour of the directus one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants