Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a UI for editing Trino connections #591

Open
whscullin opened this issue Feb 3, 2025 · 1 comment
Open

Create a UI for editing Trino connections #591

whscullin opened this issue Feb 3, 2025 · 1 comment
Assignees
@mbooth4

Comments

@whscullin
Copy link
Contributor

whscullin commented Feb 3, 2025 •
edited
Loading

Currently the only way to configure a Trino connection is via environment variables.

The existing connection editors live at:
https://github.com/malloydata/malloy-vscode-extension/tree/main/src/extension/webviews/connections_page
and the VS Code configuration lives https://github.com/malloydata/malloy-vscode-extension/blob/main/package.json#L391
@mbooth4 mbooth4 self-assigned this Feb 4, 2025
@mbooth4
Copy link
Contributor

mbooth4 commented Feb 4, 2025 •
edited
Loading

Assigning to myself. This overlaps heavily with the Presto connection type (#589), so I will be re-using some of the classes.

@mbooth4 mbooth4 mentioned this issue Feb 7, 2025
Merged
whscullin pushed a commit that referenced this issue Feb 7, 2025
@mbooth4
Add connection editors for Trino and Presto (#593)
0e13d15 
Add Editor UI for 'Presto' and 'Trino' connections.

Implements #589 and #591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbooth4 mbooth4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whscullin @mbooth4