Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept container parameters in initialize_container #30

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Accept container parameters in initialize_container #30

merged 11 commits into from
Aug 21, 2024

Conversation

maldoinc
Copy link
Owner

@maldoinc maldoinc commented Aug 11, 2024 •
edited
Loading

  • initialize_container takes a parameters arg, so there's no need to separately update container.params.

@maldoinc maldoinc changed the title Simplify initialize_container Accept container parameters in initialize_container Aug 21, 2024
@maldoinc maldoinc merged commit 7afd402 into master Aug 21, 2024
7 checks passed
@maldoinc maldoinc deleted the initialize-container-2 branch December 18, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maldoinc