Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Release mode unit tests #51

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Conversation

maksimkim
Copy link
Owner

@maksimkim maksimkim commented Oct 20, 2024

HttpUtilityTests:

Http2ConnectionHandlerTest:

  • mock FrameWriter.WriteGoAwayAsync with Task.Delay to force scheduling channel.Close

SingleThreadEventLoopTest:

  • mark two tests validating behavior of ExecuteAfterEventLoopIteration as DEBUG-only since the method itself is DEBUG-only.

misc:

  • Use proper array pool reference in ArrayPooledByteBuffer tests

@maksimkim maksimkim changed the title Align HttpUtilityTest with RFC 3986 Fix failing Release mode unit tests Oct 20, 2024
@tomkerkhove
Copy link
Collaborator

/azp run

@tomkerkhove
Copy link
Collaborator

/azp run

@tomkerkhove
Copy link
Collaborator

@tomkerkhove
Copy link
Collaborator

/azp run

@tomkerkhove tomkerkhove merged commit f18946c into main Oct 21, 2024
2 checks passed
@tomkerkhove tomkerkhove deleted the mkim/fixhttputilityreleasetest branch October 21, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants