Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't trigger for main pushes & run tests in release #47

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

tomkerkhove
Copy link
Collaborator

@tomkerkhove tomkerkhove commented Oct 17, 2024

  • Don't run CI when merged to main (as PR already did the same)
  • Run everything in Release mode, similar to release

It's good to note that tests always run in Debug anyway, as this is defined in Fake like this:

SpanNetty/build.fsx

Lines 259 to 261 in a4ba4e6

match (hasTeamCity) with
| true -> (sprintf "test -c Debug --no-build --logger:trx --logger:\"console;verbosity=normal\" --framework %s -- RunConfiguration.TargetPlatform=x64 --results-directory \"%s\" -- -parallel none -teamcity" testNetFrameworkVersion outputTests)
| false -> (sprintf "test -c Debug --no-build --logger:trx --logger:\"console;verbosity=normal\" --framework %s -- RunConfiguration.TargetPlatform=x64 --results-directory \"%s\" -- -parallel none" testNetFrameworkVersion outputTests)

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove changed the title 🏗️ ci: Don't trigger for main pushes & run tests in release ci: Don't trigger for main pushes & run tests in release Oct 17, 2024
@tomkerkhove
Copy link
Collaborator Author

I believe the primary difference we've noticed is that release pipeline was still on Incrementalist which ran tests differently and those were triggered in our CI as well.

Examples (release vs latest CI from main):
image
image

After checking, all failed tests are passing in CI so should be fine with this alignment. (although I can only test on release)

@tomkerkhove tomkerkhove requested review from maksimkim and DeagleGross and removed request for DeagleGross October 17, 2024 06:25
@tomkerkhove tomkerkhove merged commit 6777c7c into main Oct 17, 2024
2 checks passed
@tomkerkhove tomkerkhove deleted the tomkerkhove/build-in-release branch October 17, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants