Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SslStream.Write with SslStream.WriteAsync in TlsHandler to avoid eventloop deadlock during client certificate renegotiation #43

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Replace SslStream.Write with SslStream.WriteAsync in TlsHandler to avoid eventloop deadlock during client certificate renegotiation #43

merged 8 commits into from
Oct 15, 2024

Conversation

maksimkim
Copy link
Owner

No description provided.

@maksimkim
use SslStream WriteAsync(..) instead of Write(..) to prevent deadlock
be371ce
@maksimkim
1. copy data to new buffer instead of wrapping incoming memory on Fin…
5e25efc 
…ishWrapAsync

2. finish write promise upon SslStream.WriteAsync completion instead of first write to channel
3. avoid calling channel.Read() in FinishWrapAsync post handshake
@maksimkim
Copy link
Owner Author

/azp run

@tomkerkhove tomkerkhove marked this pull request as draft October 7, 2024 07:44
@maksimkim
Copy link
Owner Author

New test doesn't pass still

@DeagleGross DeagleGross marked this pull request as ready for review October 15, 2024 09:20
@DeagleGross DeagleGross merged commit a4ba4e6 into main Oct 15, 2024
2 checks passed
@tomkerkhove tomkerkhove deleted the mkim/tlsasyncwrite branch October 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeagleGross DeagleGross DeagleGross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maksimkim @DeagleGross