Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple submissions of create/update form #309

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Prevent multiple submissions of create/update form #309

merged 3 commits into from
Oct 2, 2024

Conversation

juggler31
Copy link
Contributor

No description provided.

@juggler31 juggler31 linked an issue Jul 29, 2024 that may be closed by this pull request
Fix posibility to click more than one time in create or save button #308
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (a9e2e7c) to head (64570e5).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files          32       32           
  Lines        2406     2406           
=======================================
  Hits         2192     2192           
  Misses        214      214

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juggler31 juggler31 requested a review from submarcos July 29, 2024 11:17
marcantoinedupre
marcantoinedupre approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I suggest to rephrase the title PR and the changelog item as: "Prevent multiple submissions of create/update form"

@juggler31 juggler31 added the bug label Aug 2, 2024
@juggler31 juggler31 changed the base branch from master to contraint_create_button September 4, 2024 08:55
Base automatically changed from contraint_create_button to master October 2, 2024 08:51
@submarcos submarcos changed the title fix: add contraint to click only once on create buttons Prevent multiple submissions of create/update form Oct 2, 2024
@submarcos submarcos merged commit 0e22836 into master Oct 2, 2024
12 checks passed
@submarcos submarcos deleted the disable_create_button branch October 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcantoinedupre marcantoinedupre marcantoinedupre approved these changes

@submarcos submarcos Awaiting requested review from submarcos

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix posibility to click more than one time in create or save button
3 participants
@juggler31 @marcantoinedupre @submarcos