-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subgraph for delegation history #915
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR Summary
|
Update migration page with v2 delegate requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question about the subgraph URL used
modules/gql/gql.constants.ts
Outdated
export const MAINNET_SUBGRAPH_URL = | ||
'https://query-subgraph-staging.sky.money/private/subgraphs/name/jetstreamgg/subgraph-testnet'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be /subgraph-mainnet
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I noticed the vote histories & last voted dates look different than prod, but it's the same thing on staging, so it must be an issue with the staging mainnet spock being behind or stuck for votes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm noticing some issues in the history:
- when I click to expand a delegation, it'll throw an error
- it says N/A for all delegate contract expirations
- When I compare the history for this address: 0xf65475e74c1ed6d004d5240b06e3088724dfda5d, I don't see the delegation events for BLUE or vigilant
Edit: here's a PR to fix these issues: https://github.com/makerdao/governance-portal-v2/pull/923/files
Fix history amounts, and expiration dates, increase page limit
fetchDelegatedTo
to use subgraph