This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Modernize the PSM and add negative fees #6
Open
hexonaut
wants to merge
20
commits into
master
Choose a base branch
from
v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbalabasquer
reviewed
Jun 6, 2022
gbalabasquer
reviewed
Jun 6, 2022
gbalabasquer
reviewed
Jun 6, 2022
gbalabasquer
reviewed
Jun 6, 2022
Added another PR to support assets that are not priced at $1: #7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update does a few things:
GemJoin
logic into thePsm
so there is only one contract nowdss-test
Some discussion:
cage()
as I don't really see what it gives us beyond what the debt ceiling control already give us and it saves an SLOAD. If there is some use I'm not seeing please let me know.tin
andtout
can go negative - do we want to prevent them from ever crossing? It's fairly obvious we don't want to do this as you will be able to drain the surplus buffer if this ever happened, but it would make it so you have to set thetin
andtout
in a specific order to not trigger the preventative revert. I'm leaning towards preventing this just to be super safe.