Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require the whole gem inside the gemspec #8

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Jan 30, 2023

It is bad practice to require the whole gem and its dependencies inside the gemspec that defines these dependencies 🙃

This is a fix that only requires the version.

@sunny sunny changed the title Gemspec: Do not require the whole gem inside the gemspec 💎 Do not require the whole gem inside the gemspec Jan 30, 2023
@UltiMich UltiMich merged commit a921f17 into makerbot:master Jun 7, 2024
@sunny sunny deleted the do-not-require-gems-in-gemspec branch June 8, 2024 07:19
@sunny
Copy link
Contributor Author

sunny commented Jun 10, 2024

Thanks for the merge \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants