Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom exception for error responses #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Jan 3, 2023

Hi Makerbot team and happy new year! ✨

This fixes a TODO in the code to raise a custom exception when there is an unhandled HTTP response error, allowing for more easy debug and understanding.

This also fixes when the gem would raise "#{response.code}: #{JSON.parse(response.body)['error']}" without testing if the body is in JSON or not, therefore raising a JSON::ParserError instead of a helpful error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant