[WEB-3179, 3247] fix: page name and recents empty state #6491
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
aaryan610
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/home/widgets/recents/index.tsx (1)
49-50: Consider using a more robust path checking method.The current implementation uses string.includes for path checking, which might be fragile. Consider using a more robust path matching approach.
- const isWikiApp = pathname.includes(`/${workspaceSlug.toString()}/pages`); + const isWikiApp = new RegExp(`^/${workspaceSlug.toString()}/pages(/|$)`).test(pathname);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
web/core/components/home/widgets/recents/index.tsx(3 hunks)web/core/components/home/widgets/recents/page.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (4)
web/core/components/home/widgets/recents/page.tsx (2)
13-13: LGTM! Clean import addition.The import follows the existing grouping pattern under the helpers section.
59-61: Verify null/undefined handling in getPageName.While the change to use
getPageNamealigns with the PR objectives, ensure it properly handles null/undefined values sincepageDetails?.nameis optional.Run this script to check the implementation:
✅ Verification successful
Null handling in getPageName is properly implemented ✅
The function in
web/helpers/page.helper.tssafely handles all edge cases:
- Returns
""for undefined values- Returns
"Untitled"for null or empty strings- Usage with optional chaining
pageDetails?.nameis correct🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for getPageName implementation and its null handling ast-grep --pattern 'function getPageName($_) { $$$ }'Length of output: 57
Script:
#!/bin/bash # Search for getPageName with various patterns echo "=== Arrow Function or Const Definition ===" ast-grep --pattern 'const getPageName = $_' echo -e "\n=== Export Declaration ===" ast-grep --pattern 'export const getPageName = $_' echo -e "\n=== Function Usage ===" rg "getPageName\(" -A 2 echo -e "\n=== Import Statements ===" rg "import.*getPageName"Length of output: 3476
web/core/components/home/widgets/recents/index.tsx (2)
5-5: LGTM! Clean hook import.The usePathname hook import follows Next.js best practices.
82-82: LGTM! Clean conditional rendering.The addition of
!isWikiAppcheck in the NoProjectsEmptyState rendering condition aligns with the PR objectives.
Description
This PR includes-
Type of Change
Summary by CodeRabbit
New Features
Bug Fixes