Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: module store #3202

Merged
merged 1 commit into from
Dec 20, 2023
Merged

refactor: module store #3202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/components/headers/module-issues.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const ModuleIssuesHeader: React.FC = observer(() => {
projectMember: { projectMembers },
moduleIssuesFilter: { issueFilters, updateFilters },
} = useMobxStore();
const { projectModules, getModuleById } = useModule();
const { projectModuleIds, getModuleById } = useModule();
const {
commandPalette: { toggleCreateIssueModal },
eventTracker: { setTrackElement },
Expand Down Expand Up @@ -180,7 +180,7 @@ export const ModuleIssuesHeader: React.FC = observer(() => {
width="auto"
placement="bottom-start"
>
{projectModules?.map((moduleId) => (
{projectModuleIds?.map((moduleId) => (
<ModuleDropdownOption moduleId={moduleId} />
))}
</CustomMenu>
Expand Down
4 changes: 2 additions & 2 deletions web/components/issues/select/module.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const IssueModuleSelect: React.FC<IssueModuleSelectProps> = observer((pro
const [referenceElement, setReferenceElement] = useState<HTMLButtonElement | null>(null);
const [popperElement, setPopperElement] = useState<HTMLDivElement | null>(null);
// store hooks
const { projectModules, getModuleById, fetchModules } = useModule();
const { projectModuleIds, getModuleById, fetchModules } = useModule();
// popper-js
const { styles, attributes } = usePopper(referenceElement, popperElement, {
placement: "bottom-start",
Expand All @@ -34,7 +34,7 @@ export const IssueModuleSelect: React.FC<IssueModuleSelectProps> = observer((pro

const selectedModule = value ? getModuleById(value) : null;

const options = projectModules?.map((moduleId) => {
const options = projectModuleIds?.map((moduleId) => {
const moduleDetails = getModuleById(moduleId);

return {
Expand Down
4 changes: 2 additions & 2 deletions web/components/issues/sidebar-select/module.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const SidebarModuleSelect: React.FC<Props> = observer((props) => {
const {
moduleIssues: { removeIssueFromModule, addIssueToModule },
} = useMobxStore();
const { projectModules, getModuleById } = useModule();
const { projectModuleIds, getModuleById } = useModule();

const [isUpdating, setIsUpdating] = useState(false);

Expand Down Expand Up @@ -64,7 +64,7 @@ export const SidebarModuleSelect: React.FC<Props> = observer((props) => {
});
};

const options = projectModules?.map((moduleId) => {
const options = projectModuleIds?.map((moduleId) => {
const moduleDetail = getModuleById(moduleId);
return {
value: moduleId,
Expand Down
10 changes: 5 additions & 5 deletions web/components/modules/modules-list-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@ export const ModulesListView: React.FC = observer(() => {
const {
membership: { currentProjectRole },
} = useUser();
const { projectModules } = useModule();
const { projectModuleIds } = useModule();

const { storedValue: modulesView } = useLocalStorage("modules_view", "grid");

const isEditingAllowed = !!currentProjectRole && currentProjectRole >= EUserProjectRoles.MEMBER;

if (!projectModules)
if (!projectModuleIds)
return (
<Loader className="grid grid-cols-3 gap-4 p-8">
<Loader.Item height="176px" />
Expand All @@ -43,13 +43,13 @@ export const ModulesListView: React.FC = observer(() => {

return (
<>
{projectModules.length > 0 ? (
{projectModuleIds.length > 0 ? (
<>
{modulesView === "list" && (
<div className="h-full overflow-y-auto">
<div className="flex h-full w-full justify-between">
<div className="flex h-full w-full flex-col overflow-y-auto">
{projectModules.map((moduleId) => (
{projectModuleIds.map((moduleId) => (
<ModuleListItem key={moduleId} moduleId={moduleId} />
))}
</div>
Expand All @@ -70,7 +70,7 @@ export const ModulesListView: React.FC = observer(() => {
: "lg:grid-cols-2 xl:grid-cols-3 3xl:grid-cols-4"
} auto-rows-max transition-all `}
>
{projectModules.map((moduleId) => (
{projectModuleIds.map((moduleId) => (
<ModuleCardItem key={moduleId} moduleId={moduleId} />
))}
</div>
Expand Down
Loading
Loading