Ensure that checkSync() and check() do not stall without the flags parameter

[MegaManSec]

This patch fixes an issue where the two functions would never finish if called without a second parameter. For example, check("^(a|a+)+$")

[makenowjust]

We assume the TypeScript definition is always guaranteed, so the current implementation does not consider the issue of missing the 2nd parameter of check and variations.

However, some programming languages may not have a regular expression flag, so this argument may be made optional. Let me give this some thought.

[MegaManSec]

Let me give this some thought.

Thank you. The context of this PR is that it took me a good amount of time to work out why, in JS, checkSync(expression) was hanging forever. Since no error message occurred, it was quite confusing. Maybe it would be better to error-out instead of assuming an empty-string 2nd parameter.

[makenowjust]

Maybe it would be better to error-out instead of assuming an empty-string 2nd parameter.

That sounds good to me. It helps us as a safety net.

[MegaManSec]

I've made it check that both parameters are strings, to be sure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6e64b2f) to head (f87e827).
Report is 40 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1383   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         3080      3106   +26     
  Branches       499       503    +4     
=========================================
+ Hits          3080      3106   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[makenowjust]

@MegaManSec Please run yarn lerna run format. CI failed due to the format.

[MegaManSec]

should be ok now

[makenowjust]

@MegaManSec Codecov reported the coverage is decreased. Could you add c8 ignore comments or tests for new lines?

[MegaManSec]

sure, hope that's fine.

[makenowjust]

Your fix seems wrong. I added a review and suggestions.

[makenowjust]

@MegaManSec Thank you for your contribution! I will release a new version.