Wallet 441 cw automation backup secret phrase #1075
Conversation
|
Please install eslint and prettier to the IDE that you use. There are many problems with code formatting. |
| } from '../../constants'; | ||
| import { popup, popupExpect } from '../../fixtures'; | ||
|
|
||
|
|
There was a problem hiding this comment.
please use the name-name format for file naming.
| const locators = createLocators(page); | ||
| const accountSwitcher = locators.accountSwitcher; | ||
| const firstAccount = locators.firstAccount; | ||
|
|
||
| // Perform actions and assertions | ||
| await accountSwitcher.click(); |
| popup( | ||
| "should display a secret phrase after providing password and copy phrase", | ||
| async ({ popupPage, unlockVault, providePassword }) => { | ||
| await unlockVault(); | ||
| await popupPage.getByTestId('menu-open-icon').click(); | ||
| await popupPage.getByText('Back up your secret recovery phrase').click(); | ||
| await providePassword(); | ||
|
|
||
|
|
||
| await popupExpect( | ||
| popupPage.getByRole('heading', { name: 'Back up your secret recovery phrase' }) | ||
| ).toBeVisible(); | ||
| await popupPage.getByText('Click to reveal secret recovery phrase').click(); | ||
| await popupPage.getByText('Copy secret recovery phrase').click(); | ||
|
|
||
|
|
||
|
|
||
| await popupExpect( | ||
| popupPage.getByText( | ||
| 'Copied to clipboard' | ||
| ) | ||
| ).toBeVisible(); | ||
| } |
There was a problem hiding this comment.
I just wanted to let you know that you didn't check if the secret phrase was displayed and if it was copied.
You test if the text changed after the user clicks on the copy text
|
|
||
| ); | ||
| popup( | ||
| 'should display safety tips', |
There was a problem hiding this comment.
I don't think that we need this test. Here we test UI text and no functionality
|
|
||
|
|
||
| popup( | ||
| "should timeout after providing wrong password 5 times", |
There was a problem hiding this comment.
we already have a test for locking the wallet for 5 minutes when the user types the wrong password 5 times
common/wallet.spec.ts
|
Please also update the PR name, description, provide the ticket's link, etc 
|
Make sure to fill in all the below sections.
Description
First pull request for Konrad's automation tests
// Provide a useful description of this PR, aimed at helping reviewers and contributors
Linked tickets
WALLET-XXX
Checklist
Make sure this PR title follows semantic release conventions: https://semantic-release.gitbook.io/semantic-release/#commit-message-format
If the PR adds any new text to the UI, make sure they are localized
Include a screenshot or recording if implementing significant UI or user flow change
When this PR affects architecture changes wait for review from Dmytro before merging